[WIP] i18n: fix timelineReplace#1001
Draft
Jaehyuk-Lee wants to merge 4 commits intoOverlayPlugin:mainfrom
Draft
Conversation
Collaborator
|
This is because the translations are slightly revised at each update. |
Jaehyuk-Lee
commented
Feb 9, 2026
| 'Lamebrix Strikebocks': 'Lamebrix le Mercenaire', | ||
| 'The Excruciationator': 'Plate-forme de torture polyvalente', | ||
| 'Weight of the World': 'Poids du monde', | ||
| 'Weight of the World': 'boulet de canon', |
Author
There was a problem hiding this comment.
Sources should be translated by "BNpcName" (mostly). But, some sources were translated by "Action" when the source name also exists in "Action".
"Weight of the World" is defined in both BNpcName and Action, and the translation came from Action, but it should come from BNpcName.
Jaehyuk-Lee
commented
Feb 10, 2026
| }, | ||
| 'replaceText': { | ||
| 'Advent': '降臨', | ||
| 'Advent': '降臨', // 101A: 再臨 / 1373: 降臨 |
Author
There was a problem hiding this comment.
Some English action names should be translated differently depending on its specific ID.
There are more examples in other contents, too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, some
timelineReplacehave wrong translation. Most fixes arereplaceTextwhich does not affect triggers, so those issues didn't matter much. However, there arereplaceSyncfixes too.I'm planning to inspect all
timelineReplacewith gen_raidboss_timeline_replace.ts. But there are many edge cases to take care of. It's not easy to makegen_raidboss_timeline_replace.tsgood/clean enough to be merged into the main repo. So, I don't have plan to merge that generator here.