fix(kingbase): use SPI quoteIdentifierAlways for DROP COLUMN - #2261
Closed
Aias00 wants to merge 2 commits into
Closed
fix(kingbase): use SPI quoteIdentifierAlways for DROP COLUMN#2261Aias00 wants to merge 2 commits into
Aias00 wants to merge 2 commits into
Conversation
10 tasks
Add a new SPI method that unconditionally quotes an identifier, preserving the exact name regardless of case or keyword status. Embedded delimiter characters are escaped per the dialect convention (double-quote "" for ", backtick `` for `, bracket ]] for ]). Fix removeIdentifierQuote to unescape doubled delimiters, satisfying the round-trip contract: removeIdentifierQuote(quoteIdentifierAlways(raw)).equals(raw). Implementations: - DefaultSQLIdentifierProcessor: double-quote + escape " -> "" - MysqlIdentifierProcessor: backtick + escape ` -> `` - SqlServerIdentifierProcessor: bracket + escape ] -> ]] Also add SNOWFLAKE_SQL_IDENTIFIER_PROCESSOR static field to SnowflakeMetaData, mirroring PostgreSQL/KingBase, to give Snowflake column-type enums access to the processor for downstream quoting PRs. Tests: 36 tests covering conditional vs always-quote, embedded delimiters, round-trip, reserved keywords, and case preservation across Default, MySQL, and SqlServer processors. Addresses the maintainer review on OtterMind#2187 requesting the shared SPI contract be extended before rebasing the individual dialect quoting PRs. Co-Authored-By: Claude <noreply@anthropic.com>
Replaces direct backtick concatenation with KingBaseMetaData.KINGBASE_SQL_IDENTIFIER_PROCESSOR.quoteIdentifierAlways, per the maintainer review on OtterMind#2187. Built on the SPI extension (OtterMind#2234). Closes OtterMind#2145 (superseded by this SPI-based approach) Co-Authored-By: Claude <noreply@anthropic.com>
Aias00
force-pushed
the
rework/kingbase-drop-column-via-spi
branch
from
July 27, 2026 16:09
0861412 to
032c404
Compare
3 tasks
openai0229
requested changes
Jul 28, 2026
openai0229
left a comment
openai0229
left a comment
Contributor
There was a problem hiding this comment.
This remains blocked on PR 2234 and currently has compile-only verification for the KingBase behavior. After the SPI contract is resolved and merged, rebase so this PR contains only the KingBase delta and add generated-DDL tests for DROP COLUMN with a normal name, mixed case or reserved word, and an embedded double quote. The exact output must prove that delimiter escaping comes from the processor.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the direct backtick concatenation in the old PR #2145 with
KingBaseMetaData.KINGBASE_SQL_IDENTIFIER_PROCESSOR.quoteIdentifierAlways(name), per the maintainer's architectural review on #2187. Built on the SPI extension #2234.KingBase is PostgreSQL-derived and uses double-quote identifiers. The old code used MySQL-style backticks for DROP COLUMN, producing invalid SQL. The constant is reverted to
"DROP COLUMN "(no delimiter), and the column name is quoted via the SPI processor.Verification
mvn compile-> BUILD SUCCESS (on the SPI extension branch)Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.