fix(hive): preserve column precision when scale is null#2191
Open
Aias00 wants to merge 1 commit into
Open
Conversation
buildDataType guarded with columnSize == null || decimalDigits == null, returning bare type for DECIMAL(10) (precision set, scale null). The size-only branch was unreachable dead code. Guard on columnSize only, mirroring every sibling. Same fix as Sqlite OtterMind#2167 and MySQL OtterMind#2180. Fixes OtterMind#2189 Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
Live-database verification (same bug class)Verified the same
Hive has the identical code pattern; the fix (guard on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #2189
Summary
Same dead-branch bug as Sqlite #2167 and MySQL #2180. HiveColumnTypeEnum.buildDataType guarded with if (columnSize == null || decimalDigits == null), returning bare type for DECIMAL(10) (precision set, scale null). Changed to columnSize == null only, making the size-only branch reachable.
Verification
Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.