fix(datasource): persist BigQuery project, email, and keyfile fields#2179
Open
Hamza-ali1223 wants to merge 2 commits into
Open
fix(datasource): persist BigQuery project, email, and keyfile fields#2179Hamza-ali1223 wants to merge 2 commits into
Hamza-ali1223 wants to merge 2 commits into
Conversation
arevalo69drian-max
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2178
Problem
When creating or editing a Google BigQuery connection in Chat2DB Community Edition, the form collects three custom authentication fields:
project,email, andkeyfile.While Test connection succeeds using in-memory form values, clicking Save drops these three fields because they were not declared on the persistence models. As a result:
Project,Account email, andKey fileinputs.java.sql.SQLException: Required Connection Key(s): ProjectId.Root Cause
BigQueryDBManager.javaexpectsconnectInfo.getProject(),connectInfo.getEmail(), andconnectInfo.getKeyfile()to populate Simba JDBC driver properties (ProjectId,OAuthServiceAcctEmail,OAuthPvtKeyPath).DataSource.java(domain entity) andDataSourceUpdateRequest.java(web DTO) lacked declarations forproject,email, andkeyfile.Proposed Changes
Added the three missing fields with Lombok getters/setters to:
chat2db-community-server/chat2db-community-domain/chat2db-community-domain-api/src/main/java/ai/chat2db/community/domain/api/model/datasource/DataSource.javachat2db-community-server/chat2db-community-web/src/main/java/ai/chat2db/community/web/api/model/request/data/source/DataSourceUpdateRequest.javaThese changes are additive, backwards-compatible, and do not alter existing fields.
Verification
SELECT 1 AS ok;. The query executed successfully and returned1.