fix(h2): log SET SCHEMA failure instead of swallowing - #2155
Conversation
|
This is a useful low-risk logging improvement, but the current PR is not ready to merge without validating the exception path it changes. Please add a focused |
openai0229
left a comment
There was a problem hiding this comment.
The changed SQLException path still lacks a focused H2DBManager regression test, and this branch overlaps open PR 2177. The current head does not address the detailed review comment already posted, so this remains blocked pending an updated commit and re-review.
H2DBManager had an empty catch around SET SCHEMA execution, silently swallowing failures. Add @slf4j and log.error, mirroring sibling DBManagers. Fixes OtterMind#2149 Co-Authored-By: Claude <noreply@anthropic.com>
|
Rebased onto latest main. Added 2 regression tests in H2DBManagerTest:
Tests run: 2, Failures: 0. The log output confirms the schema name and exception are logged via log.error. |
937f221 to
f5b8895
Compare
Related issue
Closes #2149
Summary
H2DBManager had an empty catch around SET SCHEMA execution, silently swallowing SQLException failures with no log. Added @slf4j and log.error, mirroring sibling DBManagers (OscarDBManager, OracleDBManager, etc.).
Verification
Contributor declaration
AI assistance: The fix, verification, and PR description were produced with Claude Code assistance.