Support matrix AB ReadNoSnp in OpenLLC#79
Closed
zykucas wants to merge 1 commit into
Closed
Conversation
Member
|
This work has been migrated to OpenXiangShan/XSAICache#5. Closing this PR in favor of the consolidated implementation there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenLLC Matrix A/B Non-Coherent Read Support (ReadNoSnp)
Summary
This PR adds OpenLLC-side support for Matrix A/B non-coherent reads issued as CHI
ReadNoSnp.Together with the matching HBL2 change, Matrix A/B
Getrequests can bypass the coherent read path and useReadNoSnp, reducing snoop/ownership overhead for matrix/GEMM workloads.Changes
matrixABmetadata to OpenLLC self directory entries.ReadNoSnphandling in the LLC MainPipe.ReadNoSnp.ReadNoSnplines.ReadNoSnp.CompDatainto the RefillUnit.ReadNoSnp/WriteNoSnpFullinteractions.ReadNoSnp.TestTopMatrixswitch:--matrix-ab-nc 1: enable Matrix A/BReadNoSnp--matrix-ab-nc 0: disable it for comparisonValidation
Basic Regression Tests
openLLC-test-matrix-traceline_trace-64-1024-64-matrix.txtopenLLC-test-l2l3540000GEMM Trace Sweep
For
openLLC-test-matrix-trace:The following full GEMM line traces were tested with Matrix A/B
ReadNoSnpenabled and disabled.line_trace-64-256-64-matrix.txtline_trace-64-512-64-matrix.txtline_trace-64-1024-64-matrix.txtline_trace-64-2048-64-matrix.txtline_trace-64-4096-64-matrix.txtline_trace-64-8192-64-matrix.txtline_trace-64-16384-64-matrix.txtOverall GEMM sweep result:
The benefit increases with the GEMM trace size and stabilizes around 1.18x for the larger traces.