perf(riscv64): static inline PMP/PMA CSR accessors#1089
Open
xiaokamikami wants to merge 1 commit into
Open
Conversation
eba3ac0 to
b646c8b
Compare
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
b646c8b to
1041569
Compare
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
1041569 to
6b69dcf
Compare
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
1a617c6 to
e7070e6
Compare
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
f4cd96a to
64ba06a
Compare
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
64ba06a to
ba75951
Compare
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
ba75951 to
de72881
Compare
NEMU Performance Results - XS Interpreter
NEMU Performance Results - XS Ref Shared Object
|
Member
|
Note the performance benefits comes from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Inline the PMP/PMA CSR accessor helpers by moving their existing implementations into
csr.hasstatic inlinefunctions.Motivation
These helpers are used by the MMU permission-check hot path. Marking only the definitions in
priv.casinlinedoes not help callers in other translation units such asmmu.c, because the compiler cannot see the function bodies there. Keeping the implementations in the header allows those calls to be inlined without changing PMP/PMA semantics.Notes
The helper logic is unchanged. This only changes linkage/placement so the compiler can inline the existing code.