Conversation
This reverts commit b62ec64.
We have already assigned a value to cpu.pbmt at the end of gpa_stage. It should not be reassigned, as this will cause it to be overwritten incorrectly: https://github.com/OpenXiangShan/NEMU/blob/112f2fd1e68d1c8978f964f6a2846104dcd928e8/src/isa/riscv64/system/mmu.c#L371-L382
When we close the address translation, We will split the cross-page store into two request. If we use the `paddr_write`'s `check_paddr` to check the PMP/PMA, The PMP/PMA checks of the two requests are separate, which will lead to: * The first request didn't have exception, it will be written to memory. * The second request hace exception, it will not to written to memory. This makes absolutely no sense! All of the request shouldn't be written! This commit allows the PMP/PMA check before the two request are written.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.