Skip to content

修复失效的图标 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cxzlw wants to merge 2 commits into
base: main
Choose a base branch
from
Open

修复失效的图标 #14

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb8b429
fix: replace Font Awesome Kit with cdnjs
cxzlw Jul 24, 2025
0310c5e
style: remove unused commented-out code
cxzlw Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<meta name="viewport" content="width=device-width, initial-scale=1.0">
<meta name="description" content="A simple weather application to get current weather information">
<link href="https://fonts.googleapis.com/css2?family=Poppins:wght@300;400;500;600;700;800;900&family=Roboto:wght@300;400;500;700;900&display=swap" rel="stylesheet">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/7.0.0/css/all.min.css">
Comment thread
cxzlw marked this conversation as resolved.

Copilot AI Jul 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font Awesome version 7.0.0 does not exist. The latest stable version is 6.x.x. Consider using a valid version like 6.5.1: https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.1/css/all.min.css

Suggested change
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/7.0.0/css/all.min.css">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.5.1/css/all.min.css">

Copilot uses AI. Check for mistakes.

Copilot AI Jul 24, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding integrity and crossorigin attributes to the CDN link for security: integrity="sha512-[hash]" crossorigin="anonymous". This ensures the resource hasn't been tampered with.

Suggested change
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/7.0.0/css/all.min.css">
<link rel="stylesheet" href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/7.0.0/css/all.min.css" integrity="sha512-<calculated-hash>" crossorigin="anonymous">

Copilot uses AI. Check for mistakes.
<link rel="stylesheet" href="style.css">
<title>Weather App | OpenTeens</title>
</head>
Expand Down Expand Up @@ -74,7 +75,6 @@ <h2 class="city-name"></h2>
Developed by OpenTeens Community
</footer>

<script src="https://kit.fontawesome.com/7c8801c017.js" crossorigin="anonymous"></script>
<script src="index.js"></script>
</body>

Expand Down