Skip to content

Use v2 donate button on legacy pages#728

Open
dergigi wants to merge 9 commits intomasterfrom
content/use-v2-donate-button-everywhere
Open

Use v2 donate button on legacy pages#728
dergigi wants to merge 9 commits intomasterfrom
content/use-v2-donate-button-everywhere

Conversation

@dergigi
Copy link
Copy Markdown
Member

@dergigi dergigi commented May 7, 2026

This routes legacy DonateRecurringButton usage through the v2 recurring donation banner so older static pages and blog posts pick up the new CTA without touching the landing page.

  • keeps existing MDX button calls working through a compatibility wrapper
  • maps nostr donations to the purple v2 banner and preserves custom CTA text
  • leaves the main landing page unchanged

Closes #715


Build preview:

@vercel
Copy link
Copy Markdown

vercel Bot commented May 7, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
os-website Ready Ready Preview, Comment May 8, 2026 9:12am

Request Review

@dergigi
Copy link
Copy Markdown
Member Author

dergigi commented May 8, 2026

Updated the remaining Nostr grant/client posts that were still using the generic recurring CTA so they now render the purple v2 banner for The Nostr Fund:

I also checked the Vercel preview on those paths and confirmed they now use the purple donate-banner-v2 variant with the Nostr designation.

@dergigi dergigi removed the request for review from Arvin21M May 8, 2026 08:05
@dergigi dergigi self-assigned this May 8, 2026
@dergigi dergigi marked this pull request as draft May 8, 2026 08:05
@dergigi
Copy link
Copy Markdown
Member Author

dergigi commented May 8, 2026

Text bleed on desktop, and on mobile it looks weird too for some reason.

Screenshot 2026-05-08 at 10 05 29 Screenshot 2026-05-08 at 10 06 54

Will investigate and fix.

Prevent MDX prose from styling the banner link and flex overflow from
pushing copy past the wedge on narrow widths; relax mobile nowrap.
Remove deprecated center wrappers site-wide under data/. Donate banners
already use horizontal margin auto; add mx-auto on fund/ops modal buttons so
they stay centered in prose without <center>.
Shrink-wrap with max-width min(480px, 100%), min-width 0 in narrow prose;
scale wedge slightly under clip and keep rotate on hover to avoid seams.
Newsletter and blog content use Tailwind typography; the banner link alone
could sit like a block glued to the prose margin. Add a full-width flex shell
with justify-center and move vertical margins to the shell so layout matches
legacy <center> behavior without touching MDX.
Avoid flex column weighting that truncated the CTA word; rely on pseudo
geometry + matching hover rotation at max-width 480px.
@dergigi
Copy link
Copy Markdown
Member Author

dergigi commented May 8, 2026

I think I fixed most issues now, so I'll mark this as ready for review @Arvin21M

@dergigi dergigi marked this pull request as ready for review May 8, 2026 09:19
Copy link
Copy Markdown
Contributor

@Arvin21M Arvin21M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mobile view: button looks tall.

Image

The following each contain at least one of the old donation buttons.

  1. /blog/thirteenth-wave-of-bitcoin-grants
  2. /blog/fourteenth-wave-of-bitcoin-grants
  3. /blog/twelfth-wave-of-bitcoin-grants
  4. /blog/thirteenth-wave-of-nostr-grants
  5. /blog/fourteenth-wave-of-nostr-grants
  6. /donate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use v2 donate button everywhere

2 participants