Refactored build toolchain for language modules#354
Open
lejcik wants to merge 2 commits into
Open
Conversation
lejcik
commented
Feb 22, 2026
| {9154D733-3414-41AB-8322-FD44D5BD311C}.Debug|x64.ActiveCfg = Debug|x64 | ||
| {9154D733-3414-41AB-8322-FD44D5BD311C}.Debug|x64.Build.0 = Debug|x64 | ||
| {9154D733-3414-41AB-8322-FD44D5BD311C}.Release|Win32.ActiveCfg = Release|Win32 | ||
| {9154D733-3414-41AB-8322-FD44D5BD311C}.Release|Win32.Build.0 = Release|Win32 |
Author
There was a problem hiding this comment.
demo plugins should not be built for release configurations, as we don't have translations for them
lejcik
commented
Feb 22, 2026
| @@ -0,0 +1,2505 @@ | |||
| [Files] | |||
| Original=$BUILD_DIR\lang\english.slg | |||
Author
There was a problem hiding this comment.
the original path to english.slg binary file was defined as: Original=..\..\bin\lang\english.slg, so translator has to know where the project binaries are (paths are different for x86 and x64 build), and this complicated the build automation, I introduced possibility to use variable BUILD_DIR, translator supports new cmd-line argument -build-dir (path), and it can expand such paths from the .atp project files
lejcik
force-pushed
the
lang-modules
branch
2 times, most recently
from
012658a to
fa6dd29
Compare
updated sln file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
I refactored the translations section of this project, because the script under
translationsdir didn't work. Now there's a new script!build_translations.cmdthat does everything. I added the missing stuff from altaptrl308.7z, files were updated to match current Salamander version. Alsotranslator.exetool needed slight update, let it can be used in automated builds.There were many maintenance files in the archive, but I focused mostly to the build part. So such maintenance scripts may not be functional. See the comments below, I explained some design decisions...