Add error_callback to ASRProcessor and use it#108
Merged
openminddev merged 2 commits intomainfrom Mar 9, 2026
Merged
Conversation
Introduce an optional error_callback to ASRProcessor and wire it from ConnectionProcessor so ASR errors can close the corresponding websocket connection. ASRProcessor now stores error_callback, logs and invokes it when the model is not initialized or when an exception occurs during streaming, stops the processor, and re-raises the error. ConnectionProcessor passes a lambda that calls ws_server.close_connection(connection_id) when available. Also adds a running-check inside the response loop and improves logging around errors and stop conditions.
Update MockASRProcessor in tests/om1_speech/processor to accept an error_callback parameter and store it as self.error_callback. This enables tests to simulate ASR error handling behavior when needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce an optional error_callback to ASRProcessor and wire it from ConnectionProcessor so ASR errors can close the corresponding websocket connection. ASRProcessor now stores error_callback, logs and invokes it when the model is not initialized or when an exception occurs during streaming, stops the processor, and re-raises the error. ConnectionProcessor passes a lambda that calls ws_server.close_connection(connection_id) when available. Also adds a running-check inside the response loop and improves logging around errors and stop conditions.