Fix for EDT violations and other small fixes.#45
Open
cmadsen wants to merge 9 commits intoOpenMap-java:masterfrom
Open
Fix for EDT violations and other small fixes.#45cmadsen wants to merge 9 commits intoOpenMap-java:masterfrom
cmadsen wants to merge 9 commits intoOpenMap-java:masterfrom
Conversation
1. QuadTreeRect.borderDistanceSqr: returned distance^4 (dx^2 squared again) instead of distance^2, causing incorrect nearest-neighbor pruning 2. QuadTreeNode.split: children were created without propagating minSize, defeating depth limits on dense data 3. QuadTreeNode.split: raw Collection<QuadTreeLeaf> replaced with parameterized Collection<QuadTreeLeaf<T>> 4. QuadTreeNode.remove: used == (identity) instead of Objects.equals(), failing for equal-but-not-same-instance objects 5. QuadTree.get: approximately_equal(west, east, .001) treated narrow bounding boxes as dateline crossings, returning global results
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes EDT violations found with https://github.com/jikuja/SwingEDTCheckAgent.
Fixes a few NPE's.
Fixes NEP when reading shape files with "empty" records.
Fixes that OMDistance, OMPoly and OmRangeRings does not respect isVisible.