Skip to content

codereview-roasted: instruct agent to check system clock for CVE date validation#116

Merged
enyst merged 1 commit intomainfrom
fix/codereview-roasted-cve-date-check
Mar 21, 2026
Merged

codereview-roasted: instruct agent to check system clock for CVE date validation#116
enyst merged 1 commit intomainfrom
fix/codereview-roasted-cve-date-check

Conversation

@aivong-openhands
Copy link
Contributor

Problem

The codereview-roasted skill can become suspicious of CVEs from years beyond the LLM's training data cutoff. For example, an agent trained on 2025 data might incorrectly flag CVE-2026-* identifiers as invalid or suspicious.

Solution

Added an explicit instruction in the Security and Correctness section telling the agent to check the system clock (date) before evaluating CVE identifiers. This ensures the agent uses the actual current year rather than assuming based on training data.

Changes

  • Added instruction to check system date when evaluating CVEs or security advisories
  • Clarifies that CVE identifiers from years beyond training cutoff are valid if system date confirms we are in that year

… validation

Training data cutoff can cause the agent to be suspicious of CVEs from
years beyond its training data (e.g., CVE-2026-* when training ended in
2025). Add explicit instruction to check the system date before
dismissing CVE identifiers as invalid.

Co-authored-by: openhands <openhands@all-hands.dev>
Copy link
Contributor

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Simple, pragmatic fix to a real problem. Agents shouldn't flag valid CVEs just because they're from years beyond training data. Checking the system clock is the right approach.

@aivong-openhands aivong-openhands marked this pull request as ready for review March 21, 2026 05:13
Copy link
Contributor

@all-hands-bot all-hands-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Good taste - Simple instruction that solves a real problem: agents shouldn't flag valid CVEs just because the year exceeds their training cutoff. Checking the system clock is the right pragmatic fix.

Copy link
Collaborator

@enyst enyst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it, thank you!

@enyst enyst merged commit acd65e6 into main Mar 21, 2026
5 checks passed
aivong-openhands pushed a commit to OpenHands/software-agent-sdk that referenced this pull request Mar 22, 2026
This change helps agents recognize that their training data may have a cutoff
date earlier than the current system clock. When evaluating time-sensitive
information like CVE identifiers (e.g., CVE-2026-*), the agent should trust
the system clock rather than making assumptions based on training data.

Closes OpenHands/extensions#116

Co-authored-by: openhands <openhands@all-hands.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants