Open
Conversation
…tration - SKILL.md: 6-phase upgrade workflow (inventory, build, API, config, SQL, test) covering Spark 2.x→3.x and 3.x→4.x with actionable checklists - README.md: human-readable overview with trigger keywords and examples - references/api-changes.md: removed/deprecated API catalog with before/after code - references/config-changes.md: config property rename/removal mapping - Registered in marketplaces/large-codebase.json Co-authored-by: openhands <openhands@all-hands.dev>
Replace references/api-changes.md and references/config-changes.md with the canonical upstream URL: https://spark.apache.org/docs/latest/migration-guide.html Co-authored-by: openhands <openhands@all-hands.dev>
The guide is most relevant during inventory — read it before making changes. Co-authored-by: openhands <openhands@all-hands.dev>
Contributor
all-hands-bot
left a comment
all-hands-bot
left a comment
There was a problem hiding this comment.
🟡 Acceptable - Comprehensive skill for a real problem. Verify marketplace registration to avoid CI failures.
| "evaluation", | ||
| "reporting" | ||
| ] | ||
| }, |
Contributor
There was a problem hiding this comment.
🟠 Important: Per AGENTS.md CI guidance, "every directory under skills/ should be listed in marketplaces/default.json." This PR only adds the skill to large-codebase.json. Verify whether it also needs to be in default.json to prevent CI failures, or if specialized marketplace registration is sufficient.
Contributor
Author
There was a problem hiding this comment.
The guidance is out-dated -- skills must be in some marketplace. I've updated the AGENTS.md file accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a skill (registered to the
large-codebasemarketplace) that walks an agent through the process of upgrading major versions of Spark.The skill queries Apache's migration guide, identifies the necessary changes, and ensures the project builds and all tests pass before completing.