-
Notifications
You must be signed in to change notification settings - Fork 11
add cofactor example as a cookbook #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| @@ -0,0 +1,372 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe its worth adding a note that we will be using pre-charged ligands here and pointing to the charge-molecules CLI docs for more info on how to generate these files?
I would also add a warning box highlighting that supplying cofactors this way means they are parameterised using the small molecule force field, I am not sure if its also worth highlighting how a different force field could be used or if that would confuse things.
Reply via ReviewNB
| @@ -0,0 +1,372 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| @@ -0,0 +1,372 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line #4. offmol.assign_partial_charges('am1bcc')
This is no longer needed as the charges are in the SDF file.
Reply via ReviewNB
jthorton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor changes, but overall this looks great, thanks for finishing it after many years!
continuation of #91 - making a new PR to not spam everyone tagged there.