Merge dev branch into dev-tc branch #3191
Merged
+10,715
−3,996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove extra `IMPLICIT NONE` statements - change name SeaSt_GetWaveFieldPointer_C to SeaSt_C_GetWaveFieldPointer (matches convention elsewehre)
- SeaSt_C_GetFluidVelAccDens - SeaSt_C_GetSurfElev
…eVelAcc - add acceleration output (similar to `dev-tc` usage) - I don't see anything that directly uses this.
- SeaSt_C_GetWaveFieldPointer - convert to subroutine, add error handling, add DebugLevel - SeaSt_C_SetWaveFieldPointer - new routine - python lib: revisions to support above, and also to support a new regression test (in progress)
making sure to close file handle in ofio turbsim reader
the flag for node in or out of water is sufficient. The density is constant throughout the water column.
- removed outdated SeaState.py example since it is no longer compatible
- remove WrVTK_inDxy from the interface - fix some broken error handling
- clears out memory that is allocated within the c-bindings library that the _End routine doesn't catch
these are all subroutine calls, so no returns
These don't need to be passed
GH: update the PR template: include AI section, r-test update
There was no reason to keep 8 decimal places
update regression test
Updates to SeaState c-bindings library interface
* Currently only supports 3D and 4D interpolation. Can add 2D interpolation in the future if needed. * Supports interpolation of scalar data, 3-by-1 vector data, and 6-by-1 vector data. * Will use C1 continuous cubic interpolation if possible. Toward grid boundary, quadratic interpolation is used. Linear interpolation is used if only two grid points are present. * If one of the grid dimensions has only 1 grid point, this dimension is effectively ignored. * Each dimension can be indicated as either periodic or not. * Periodic dimensions will always use cubic interpolation because the grid is effectively infinite in this direction. * For non-periodic dimensions, a query point will be snapped back to the grid boundary if out of bound. A warning will be given at the first occurrence. * Note that for periodic dimensions, the subroutines assume the first and last grid points are NOT duplicates of each other.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 134 out of 152 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
andrew-platt
approved these changes
Feb 6, 2026
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
I've seen all these changes before. I didn't review it in detail, but they are ready for merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
This PR merges the
devbranch into thedev-tcbranch in preparation of makingdev-tcthe newdevbranch, which will then become OpenFAST 5.0.Test results, if applicable