Fix type of TestCase#311
Open
alxmtaylor wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
When running the conformance test suite from the CLI using
./fcs, the results are not output correctly if there are any failures alongside test passesThe fix:
TestCaseinhandlers.goshould correspond to theTestCasein in result.go which isFail []string json:"fail,omitempty"How to test:
Run test suite using the CLI tool using your preferred config, where you know at least one test will fail, eg
Before this change you should see that the output of the above command would fail to output any failing test results. After this change you should see that failing test results are output correctly with the failure message along with any passes