Fix OpenCRE Chat UI layout issues (#625)#745
Open
Mahaboobunnisa123 wants to merge 1 commit intoOWASP:mainfrom
Open
Fix OpenCRE Chat UI layout issues (#625)#745Mahaboobunnisa123 wants to merge 1 commit intoOWASP:mainfrom
Mahaboobunnisa123 wants to merge 1 commit intoOWASP:mainfrom
Conversation
- Fix invalid CSS 'line-height: 1.6 consideration' to 'line-height: 1.6' - Add margin-top to typing indicator for loading spinner spacing - Increase chatbot title margin-top and layout padding-top to prevent heading from touching the navbar Signed-off-by: Mahaboobunnisa123 <mdshabbi885@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #625 — Improves the UI of the OpenCRE Chat page by addressing three layout issues.
Changes Made
1. Fix chatbot response display (CSS syntax error)
application/frontend/src/pages/chatbot/chatbot.scss(line 121)line-height: 1.6 consideration;— the wordconsiderationis an invalid CSS value, causing the browser to silently ignore the entireline-heightpropertyline-height: 1.6;2. Add top margin to loading spinner (typing indicator)
application/frontend/src/pages/chatbot/chatbot.scssmargin-top: 0.5remto.typing-indicator3. Add spacing between heading and navbar
application/frontend/src/pages/chatbot/chatbot.scssmargin-topon.chatbot-titlefrom2rem→3remand addedpadding-top: 1remto.chatbot-layoutTesting
Screenshot
I noticed this issue has had no progress, so I've investigated and found the root causes:
A CSS syntax error (line-height: 1.6 consideration) causing improper response display
Missing margin-top on the typing indicator
Insufficient spacing between the title and navbar
I've opened a PR with fixes. Happy to make any changes based on your review!
Thank you!