Fix encoding issues#12
Open
sebkur wants to merge 2 commits into
Open
Conversation
Some files contained characters that were not encoded as proper unicode.
Some files contained dos-style CRLF line-endings (and also trailing whitespace)
Author
|
I'm working on some improvements in other branches but will wait with pull requests on those because they contain the above commits, too: |
|
You should probably just fork this project, at this point. Seems to be abandoned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have started working on a GitHub version of JMapProjLib a few years ago and while picking up this work, I realized you have created a more popular fork in the meantime. Instead of working on my own separate version, I would like to participate in the evolution of this project here.
While setting up your project locally, I noticed some files were not properly UTF-8 encoded. Other platforms, including GitHub itself, have problems with this encoding, which is also visible in the rendering of the files and the diffs here on the GitHub website (see the diff of this PR as an example).
Also, four files contained dos-style line-endings, which is discouraged for files checked into Git (if you're working on Windows, git can be configured, also on a per-repository basis, to check in files with the recommended Unix line endings and check out using DOS line-endings on your machine. See
https://help.github.com/articles/dealing-with-line-endings for more information).
Those are the relevant files:
src/com/jhlabs/map/GeodeticPosition.javasrc/com/jhlabs/map/proj/NZMGProjection.javasrc/com/jhlabs/map/proj/SwissObliqueMercatorProjection.javasrc/com/jhlabs/map/proj/UniversalTransverseMercatorProjection.javaIt would be awesome if you accepted this pull request and try to configure your IDE and git to avoid these problems in the future. Thanks