Feature/incorporate images #15
Conversation
sempervent
left a comment
sempervent
left a comment
There was a problem hiding this comment.
a few clarifying questions and comments
| from fastapi import Depends, FastAPI, File, Form, HTTPException, Request, Response, Security, UploadFile | ||
| from fastapi.responses import JSONResponse, RedirectResponse | ||
| from fastapi.security.api_key import APIKeyHeader | ||
| from loguru import logger | ||
| from prometheus_client import CONTENT_TYPE_LATEST, Counter, Histogram, generate_latest | ||
| from pydantic import BaseModel | ||
| from sqlalchemy import create_engine, or_, select, text | ||
| from sqlalchemy.exc import IntegrityError, SQLAlchemyError | ||
| from sqlalchemy.orm import Session, sessionmaker |
There was a problem hiding this comment.
should we guard this with a try, raise ImportError from exc with a message to install the backend? or move that logic to init.py for backend?
There was a problem hiding this comment.
Do we expect folks to try and run this bare metal?
I was thinking it wouldn't be necessary since we are using this in the image (which will have the extra automatically installed through the Dockerfile)
There was a problem hiding this comment.
I think we may expect them to run it in bare metal. At least we should be prepared for the ask as Docker might not be feasible on all systems.
opensampl/server/migrations/_migrations/versions/2025_09_22_0915_campus_view_not_forced.py
Show resolved
Hide resolved
sempervent
left a comment
sempervent
left a comment
There was a problem hiding this comment.
we will want to position ourselves later (doesn't have to be this MR) for possible bare-metal installs.
TODO: add changelog & fix ruff/ ty for the migrations and backend