-
Notifications
You must be signed in to change notification settings - Fork 16
Bump playwright and @playwright/test in /tests/end-to-end/web-UI #1733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JoshuaSBrown
wants to merge
682
commits into
devel
Choose a base branch
from
dependabot/npm_and_yarn/tests/end-to-end/web-UI/multi-a50d7f32cf-2
base: devel
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump playwright and @playwright/test in /tests/end-to-end/web-UI #1733
JoshuaSBrown
wants to merge
682
commits into
devel
from
dependabot/npm_and_yarn/tests/end-to-end/web-UI/multi-a50d7f32cf-2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scanning 1216 daps feature add improved ci scanning
Update nlhoman json version
* Add additional params to DatabaseAPI::userSetAccessToken to pass message with addtional info on to database API. * Add convenience method with old type signature of DatabaseAPI::userSetAccessToken for compatibility * Conditionally add other token options param when calling dbGetRaw. * Pass token type along to Database API. * Pass token type from message. * Extract logic for building URL from dbPost and dbGetRaw into separate function for easier testing and debugging * Extract url building logic from dbGet * Add some comments for moved code, address a TODO, add new TODO for AccessToken Message type field * Address default on token type, formatting * Add new AccessTokenType entries for a sentinel value and Globus default in SDMS.proto, use as desired in DatabaseAPI.cpp * Change query param to match backend changes * Restore formatting of SDMS.proto * Make built URL const where appropriate in DatabaseAPI.cpp and DatabaseAPI.hpp * Change default AccessTokenType for UserSetAccessTokenRequest in SDMS_Auth.proto. * Remove logging of potentially senitive data * Adjust AccessTokenType ACCESS_SENTINEL to have value of uint8 max. --------- Co-authored-by: Anthony Ramirez <[email protected]>
[DLT-1110] Add controller unit tests [DLT-1110] Remove debug [DLT-1110] Correct import statements, endpoint list [DLT-1110] Refactor out into MVC [DLT-1110] Add debug [DLT-1110] Functioning modal, needs refactoring [DLT-1110] Refactor dlg start transfer using OOO programming. Should be MVC cased on what I'm seeing but we'll see
…ransfer request when update or get
…to lib/error_codes.js (#1679)
* style: Removed non helpful logs from tasks.js * fix: reverted protobuf to match devel (a9b006) * refactor: Refactoered the user_router to have a first pass of standardized logging (needs more testing) * style:Fomratted with prettier * refactor: changed correlation id within logs to use req.headers['x-correlation-id'] instead of just having placeholder text * chore: Auto-format JavaScript files with Prettier * refactor: First pass of logging within user_router.js * refactor: last minute changes * chore: Auto-format JavaScript files with Prettier * Refactor: Added second pass of logging to user router * Forgot to also add the new file * chore: Auto-format JavaScript files with Prettier * chore: Auto-format JavaScript files with Prettier * refactor:Made final adjustments to logging within user router * chore: Auto-format JavaScript files with Prettier * refactor: replaced undefined with null for appropriate areas; made slight changes to some log output to obfuscate sensitive data * refactor: Fixed spacing within logs; Removed unnecessary logging * chore: Auto-format JavaScript files with Prettier * chore: Auto-format JavaScript files with Prettier * style: Removed non helpful logs from tasks.js * fix: reverted protobuf to match devel (a9b006) * chore: Auto-format JavaScript files with Prettier * refactor: Fixed spacing within logs; Removed unnecessary logging * chore: Auto-format JavaScript files with Prettier * chore: Auto-format JavaScript files with Prettier * Style: Corrected status' on logs Co-authored-by: Joshua S Brown <[email protected]> * refactor:Second pass of user_router logging * refactor: Removed temporary logger file * refactor:removed external/protobuf * refactor: Final touches for logging * chore: Auto-format JavaScript files with Prettier * refactor: Cleaning up PII issues * refactor:Final checks, changed /view's extra output * Submodule update * refactor: Commited all reviewed changes * chore: Auto-format JavaScript files with Prettier --------- Co-authored-by: Joshua S Brown <[email protected]>
#1691) * refactor: adjust validation.js swap g_lib with error_code require remove circular dependency from validation.js by removing validateRepositorySupportsDataOperations Co-authored-by: Aaron Perez <[email protected]>
…s to lib/permissions (#1695)
…tadata and globus (#1697) Co-authored-by: Aaron Perez <[email protected]>
…m, add RepoAllocationCreateResponse (#1719)
…ional fields when creating repo to support metadat… (#1714)
…ptional in repoCreateRequest (#1716)
…outer create (#1706) Co-authored-by: Aaron Perez <[email protected]>
…3 globus_sdk version pinned (#1689)
…uilding the container image from incorrect sha (#1732)
Bumps [playwright](https://github.com/microsoft/playwright) and [@playwright/test](https://github.com/microsoft/playwright). These dependencies needed to be updated together. Updates `playwright` from 1.45.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.45.1...v1.56.1) Updates `@playwright/test` from 1.45.1 to 1.56.1 - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.45.1...v1.56.1) --- updated-dependencies: - dependency-name: playwright dependency-version: 1.56.1 dependency-type: direct:production - dependency-name: "@playwright/test" dependency-version: 1.56.1 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgraded Playwright packages by bumping both @playwright/test and playwright from 1.45.1 to 1.56.1 via package.json updates and lockfile regeneration. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps playwright and @playwright/test. These dependencies needed to be updated together.
Updates
playwrightfrom 1.45.1 to 1.56.1Updates
@playwright/testfrom 1.45.1 to 1.56.1updated-dependencies:
Ticket
Description
How Has This Been Tested?
Artifacts (if appropriate):
Tasks
Summary by Sourcery
Build: