Skip to content

Conversation

@JoshuaSBrown
Copy link
Collaborator

@JoshuaSBrown JoshuaSBrown commented Oct 28, 2025

Bumps playwright and @playwright/test. These dependencies needed to be updated together.

Updates playwright from 1.45.1 to 1.56.1

Updates @playwright/test from 1.45.1 to 1.56.1


updated-dependencies:

  • dependency-name: playwright dependency-version: 1.56.1 dependency-type: direct:production
  • dependency-name: "@playwright/test" dependency-version: 1.56.1 dependency-type: direct:development ...

Ticket

Description

How Has This Been Tested?

Artifacts (if appropriate):

Tasks

  • - A description of the PR has been provided, and a diagram included if it is a new feature.
  • - Formatter has been run
  • - CHANGELOG comment has been added
  • - Labels have been assigned to the pr
  • - A reviwer has been added
  • - A user has been assigned to work on the pr
  • - If new feature a unit test has been added

Summary by Sourcery

Build:

  • Bump playwright and @playwright/test from 1.45.1 to 1.56.1 in the web UI end-to-end test suite

JoshuaSBrown and others added 30 commits January 13, 2025 10:27
…scanning

1216 daps feature add improved ci scanning
* Add additional params to DatabaseAPI::userSetAccessToken to pass message with addtional info on to database API.

* Add convenience method with old type signature of DatabaseAPI::userSetAccessToken for compatibility

* Conditionally add other token options param when calling dbGetRaw.

* Pass token type along to Database API.

* Pass token type from message.

* Extract logic for building URL from dbPost and dbGetRaw into separate function for easier testing and debugging

* Extract url building logic from dbGet

* Add some comments for moved code, address a TODO, add new TODO for AccessToken Message type field

* Address default on token type, formatting

* Add new AccessTokenType entries for a sentinel value and Globus default in SDMS.proto, use as desired in DatabaseAPI.cpp

* Change query param to match backend changes

* Restore formatting of SDMS.proto

* Make built URL const where appropriate in DatabaseAPI.cpp and DatabaseAPI.hpp

* Change default AccessTokenType for UserSetAccessTokenRequest in SDMS_Auth.proto.

* Remove logging of potentially senitive data

* Adjust AccessTokenType ACCESS_SENTINEL to have value of uint8 max.

---------

Co-authored-by: Anthony Ramirez <[email protected]>
[DLT-1110] Add controller unit tests
[DLT-1110] Remove debug
[DLT-1110] Correct import statements, endpoint list
[DLT-1110] Refactor out into MVC
[DLT-1110] Add debug
[DLT-1110] Functioning modal, needs refactoring
[DLT-1110] Refactor dlg start transfer using OOO programming. Should be MVC cased on what I'm seeing but we'll see
JoshuaSBrown and others added 24 commits October 2, 2025 13:29
* style: Removed non helpful logs from tasks.js

* fix: reverted protobuf to match devel (a9b006)

* refactor: Refactoered the user_router to have a first pass of
standardized logging (needs more testing)

* style:Fomratted with prettier

* refactor: changed correlation id within logs to use
req.headers['x-correlation-id'] instead of just having placeholder text

* chore: Auto-format JavaScript files with Prettier

* refactor: First pass of logging within user_router.js

* refactor: last minute changes

* chore: Auto-format JavaScript files with Prettier

* Refactor: Added second pass of logging to user router

* Forgot to also add the new file

* chore: Auto-format JavaScript files with Prettier

* chore: Auto-format JavaScript files with Prettier

* refactor:Made final adjustments to logging within user router

* chore: Auto-format JavaScript files with Prettier

* refactor: replaced undefined with null for appropriate areas; made
slight changes to some log output to obfuscate sensitive data

* refactor: Fixed spacing within logs; Removed unnecessary logging

* chore: Auto-format JavaScript files with Prettier

* chore: Auto-format JavaScript files with Prettier

* style: Removed non helpful logs from tasks.js

* fix: reverted protobuf to match devel (a9b006)

* chore: Auto-format JavaScript files with Prettier

* refactor: Fixed spacing within logs; Removed unnecessary logging

* chore: Auto-format JavaScript files with Prettier

* chore: Auto-format JavaScript files with Prettier

* Style: Corrected status' on logs

Co-authored-by: Joshua S Brown <[email protected]>

* refactor:Second pass of user_router logging

* refactor: Removed temporary logger file

* refactor:removed external/protobuf

* refactor: Final touches for logging

* chore: Auto-format JavaScript files with Prettier

* refactor: Cleaning up PII issues

* refactor:Final checks, changed /view's extra output

* Submodule update

* refactor: Commited all reviewed changes

* chore: Auto-format JavaScript files with Prettier

---------

Co-authored-by: Joshua S Brown <[email protected]>
#1691)

* refactor: adjust validation.js swap g_lib with error_code require remove circular dependency from validation.js by removing validateRepositorySupportsDataOperations

Co-authored-by: Aaron Perez <[email protected]>
…ional fields when creating repo to support metadat… (#1714)
…uilding the container image from incorrect sha (#1732)
Bumps [playwright](https://github.com/microsoft/playwright) and [@playwright/test](https://github.com/microsoft/playwright). These dependencies needed to be updated together.

Updates `playwright` from 1.45.1 to 1.56.1
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.45.1...v1.56.1)

Updates `@playwright/test` from 1.45.1 to 1.56.1
- [Release notes](https://github.com/microsoft/playwright/releases)
- [Commits](microsoft/playwright@v1.45.1...v1.56.1)

---
updated-dependencies:
- dependency-name: playwright
  dependency-version: 1.56.1
  dependency-type: direct:production
- dependency-name: "@playwright/test"
  dependency-version: 1.56.1
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Oct 28, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Upgraded Playwright packages by bumping both @playwright/test and playwright from 1.45.1 to 1.56.1 via package.json updates and lockfile regeneration.

File-Level Changes

Change Details Files
Bump Playwright dependencies to v1.56.1
  • Update @playwright/test devDependency from ^1.45.1 to ^1.56.1
  • Update playwright dependency from ^1.45.1 to ^1.56.1
  • Regenerate package-lock.json to reflect updated versions
tests/end-to-end/web-UI/package.json
tests/end-to-end/web-UI/package-lock.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: Low Lower priority work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants