Remove redundant keys from zebedee configuration#290
Open
lindenmckenzie wants to merge 1 commit into
Open
Conversation
jessjenkins
previously approved these changes
Mar 23, 2026
jessjenkins
reviewed
Mar 23, 2026
Comment on lines
-38
to
-39
| KEYRING_SECRET_KEY: "38c03PzhNuSrYV8J0537XQ==" | ||
| KEYRING_INIT_VECTOR: "RkL9MmjfRcPB86alO82gHQ==" |
Contributor
There was a problem hiding this comment.
These two seem to still be in use in zebedee, are you sure they aren't needed? Might be defined elsewhere though so just asking the question.
Contributor
Author
There was a problem hiding this comment.
yeah you're absolutely right - I did stop removing these but must have committed one by mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed redundant keys from zebedee configuration
How to review
Check looks ok and that the keys aren't used anymore.
Who can review
Not me.