[18.0][ADD] webservice_server_env: make server_environment an optional dependency#101
[18.0][ADD] webservice_server_env: make server_environment an optional dependency#101
Conversation
|
Hi @etobella, |
dreispt
force-pushed
the
18-dr-webservice_server_env
branch
2 times, most recently
from
62ea7a3 to
5ccd5f6
Compare
dreispt
force-pushed
the
18-dr-webservice_server_env
branch
from
5ccd5f6 to
04908b5
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
dreispt
removed
the
stale
|
Any reason to hold this back? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Just time to review it and test it on real life project 😅 |
| @@ -0,0 +1 @@ | |||
| ../../../../webservice_server_env No newline at end of file | |||
There was a problem hiding this comment.
setup folder is a leftover from the porting ;)
There was a problem hiding this comment.
Do you want to take over and make a superseding PR, since you are working on this right now?
There was a problem hiding this comment.
I'm not working on it. Here you should just exclude the setup folder from the cherry-pick 😉
simahawk
left a comment
simahawk
left a comment
There was a problem hiding this comment.
LGTM, mere code review, no test
3 participants
Forward port of #42