[NEW] survey_record_generation by clementelabore · Pull Request #149 · OCA/survey

clementelabore · 2025-02-28T13:15:00Z

A new module used to create records when user responds to a survey.

github-actions · 2025-07-27T12:15:53Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

gurneyalex · 2025-09-17T14:27:43Z

@OCA/crm-sales-marketing-maintainers I'm discussing with the authors of this module at OCA days and reopened the PR. I think it is interesting, and your feedback is welcome.

gurneyalex · 2025-09-17T14:33:05Z

@petrus-v Could there be a path on this for the product configuration?

gurneyalex

First review, not super in depth, with some typo fixes and rewording suggestions.

I would like to see some automated tests for this module.

Having in the data an example of the module an example survey, for instance the "typical case" explained (or a subset which does not require a dependency on crm could be a great addition.

gurneyalex · 2025-09-17T17:13:27Z

survey_record_generation/readme/DESCRIPTION.rst

@@ -0,0 +1 @@
+This module allows to generate any record from surveys answers.


Suggested change

This module allows to generate any record from surveys answers.

This module allows to generate any record from survey answers.

gurneyalex · 2025-09-17T17:14:31Z

survey_record_generation/readme/CONFIGURE.rst

+.. |Image of record creation list| image:: ../static/description/record-creations.png
+
+#. Go to the the survey
+#. In *Record creation* tab add a new line        


Suggested change

#. In *Record creation* tab add a new line

#. In the *Record creation* tab, add a new line

gurneyalex · 2025-09-17T17:15:47Z

survey_record_generation/readme/CONFIGURE.rst

+
+#. Go to the the survey
+#. In *Record creation* tab add a new line        
+#. Set a name for created record, select the Model of the record (eg: Prospect)


It is not clear reading this what the name will be used for. It also seems there are two steps. Or setting a name and selecting the model is the same thing?

gurneyalex · 2025-09-17T17:17:06Z

survey_record_generation/readme/CONFIGURE.rst

+    .. |Image of record creation fields| image:: ../static/description/record-creation-customer.png
+
+    #. You can check "unicity constraint" to prevent duplicates. 
+        In case of duplicates and if other record use this record to fill a m2o field, the founded record will be used


Suggested change

In case of duplicates and if other record use this record to fill a m2o field, the founded record will be used

In case of duplicates and if other records use this record to fill a m2o field, the already present record will be used

gurneyalex · 2025-09-17T17:17:34Z

survey_record_generation/readme/CONFIGURE.rst

+
+    #. You can check "unicity constraint" to prevent duplicates. 
+        In case of duplicates and if other record use this record to fill a m2o field, the founded record will be used
+    #. You can configure explicitly where Odoo should retrieve the value of field : 


Suggested change

#. You can configure explicitly where Odoo should retrieve the value of field :

#. You can configure explicitly how Odoo should retrieve the value of field :

gurneyalex · 2025-09-17T17:31:54Z

survey_record_generation/models/survey_question.py

+            if not rec:
+                raise UserError(_("No record found in %s", self.model_id.name))
+            else:
+                for answer in self.suggested_answer_ids:


can you explain the logic of this onchange? Maybe it's me not understanding the structure of the Survey models but this looks strange.

gurneyalex · 2025-09-17T17:33:30Z

survey_record_generation/models/survey_question_answer.py

+    )
+    model_id = fields.Many2one("ir.model", related="question_id.model_id")
+    answer_values_type = fields.Selection(related="question_id.answer_values_type")
+    value_char = fields.Char("Value")


Can you add a help string explaining what this field is for?

gurneyalex · 2025-09-17T18:45:40Z

survey_record_generation/models/survey_generated_record.py

+    survey_record_creation_id = fields.Many2one(
+        "survey.record.creation", "Survey record creation", readonly=True
+    )
+    user_input_id = fields.Many2one("survey.user_input", "Participation", readonly=True)


Not sure about the name. Is it a leftover from a version not in English?

gurneyalex · 2025-09-17T18:46:15Z

survey_record_generation/models/survey_survey.py

+    survey_record_creation_ids = fields.One2many(
+        "survey.record.creation",
+        "survey_id",
+        "Records creation",


Suggested change

"Records creation",

"Created records",

gurneyalex · 2025-09-17T18:47:48Z

survey_record_generation/models/survey_question_answer.py

+    def _selection_target_model(self):
+        return [
+            (model.model, model.name)
+            for model in self.env["ir.model"].sudo().search([])


same remark about the domain

github-actions · 2026-01-18T12:16:05Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

clementelabore force-pushed the 16.0 branch from e8236de to 4903808 Compare February 28, 2025 13:33

[NEW] survey_record_generation

2366568

clementelabore force-pushed the 16.0 branch from 4903808 to 2366568 Compare February 28, 2025 13:36

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jul 27, 2025

github-actions bot closed this Aug 31, 2025

gurneyalex reopened this Sep 17, 2025

gurneyalex added work in progress and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Sep 17, 2025

gurneyalex reviewed Sep 17, 2025

View reviewed changes

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 18, 2026

		@@ -0,0 +1 @@
		This module allows to generate any record from surveys answers. No newline at end of file

	#. In Record creation tab add a new line
	#. In the Record creation tab, add a new line

	In case of duplicates and if other record use this record to fill a m2o field, the founded record will be used
	In case of duplicates and if other records use this record to fill a m2o field, the already present record will be used

	#. You can configure explicitly where Odoo should retrieve the value of field :
	#. You can configure explicitly how Odoo should retrieve the value of field :

Uh oh!

Conversation

clementelabore commented Feb 28, 2025

Uh oh!

github-actions bot commented Jul 27, 2025

Uh oh!

gurneyalex commented Sep 17, 2025

Uh oh!

gurneyalex commented Sep 17, 2025

Uh oh!

gurneyalex left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants