[19.0] account_cutoff_base: Move the constraint on uniqueness for cutoff date at line level - #382
Open
petrus-v wants to merge 163 commits into
Open
[19.0] account_cutoff_base: Move the constraint on uniqueness for cutoff date at line level#382petrus-v wants to merge 163 commits into
petrus-v wants to merge 163 commits into
Conversation
Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy
….get('type', '-')
…de domains) On account.account, type must be <> 'view' and <> 'closed'
…a single warning left ! Add translation template files.
The signature of existing methods is preserved.
Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid
Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files
Currently translated at 100,0% (73 of 73 strings) Translation: account-closing-11.0/account-closing-11.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-11-0/account-closing-11-0-account_cutoff_base/de/
Add record rules for cutoff lines and cutoff tax lines
On account.cutoff, the domain for the cutoff journal has type='general', like on the default value the accounting config page
Fix license in manifest which was set to LGPL by mistake in the migration commit from v16 to v17
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-18.0/account-closing-18.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-18-0/account-closing-18-0-account_cutoff_base/
Currently translated at 100.0% (132 of 132 strings) Translation: account-closing-18.0/account-closing-18.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-18-0/account-closing-18-0-account_cutoff_base/it/
Currently translated at 100.0% (132 of 132 strings) Translation: account-closing-18.0/account-closing-18.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-18-0/account-closing-18-0-account_cutoff_base/fr/
Currently translated at 100.0% (132 of 132 strings) Translation: account-closing-18.0/account-closing-18.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-18-0/account-closing-18-0-account_cutoff_base/es_AR/
in order to reduce the record set to loop on
Allow to automatically reverse generated moves
Allow to configure different account for refunds (credit notes)
OCA-git-bot
added
series:19.0
mod:account_cutoff_base
petrus-v
commented
Jul 16, 2026
…ff date at line level + Add the possibility to create several cutoff with the same date + Add a configuration to check cutoff date unicity either on lines or on the whole cutoff
Business case can be :
- One user (A) creates a cutoff for some account moves. Another user (B) creates other moves, then wants to see those moves in a cutoff.
However, B does not want to interfere with the cutoff A already made. B creates a new cutoff with the same date as the one of A, and when he generates lines,
only retrieves the one that were not already in the cutoff of A.
- One user wants to create several cutoff at the same date, but for different journals/accounts
petrus-v
force-pushed
the
19.0-account_cutoff-port-343-move-constraints
branch
from
July 16, 2026 14:38
d25537a to
b6d4c24
Compare
AnizR
approved these changes
Jul 17, 2026
AnizR
left a comment
AnizR
left a comment
There was a problem hiding this comment.
I reviewed only the last commit that integrates
Code LGTM and I think that you fixed a bug here (using id of lines to search on parent): https://github.com/OCA/account-closing/pull/343/changes#diff-191f90fce2c30a95de8f7309b0045c5a9827577f933e93e9d4576cb5ba2d530dR128
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
port #343 account_cutoff_base part on top of #381