Fix/simplify ipad plugin#3055
Open
adenwuts wants to merge 2 commits into
Open
Conversation
iOS Safari 26.5 seems to change the interactions between this plugin and and touch events, resulting in double-clicks on touch which break any 'toggleable' menus (e.g. add torrent). Unfortunately without this plugin we lose a working right-click on long-presses and functionality in the side-bar. This commit attempts to strip down the plugin to a more minimal set of features, and rely on iOS to handle more of the work. There may be a more elegant fix in the ruTorrent internals that would make this plugin redundant, but this appears to fix the issues on modern iOS versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iOS Safari 26.5 seems to change the interactions between this plugin and
and touch events, resulting in double-clicks on touch which break any
'toggleable' menus (e.g. add torrent). Unfortunately without this plugin
we lose a working right-click on long-presses and functionality in the
side-bar.
This commit attempts to strip down the plugin to a more minimal set of
features, and rely on iOS to handle more of the work. There may be a
more elegant fix in the ruTorrent internals that would make this plugin
redundant, but this appears to fix the issues on modern iOS versions.