fix(config): dotenv override existing env#166
Merged
Conversation
PM2 daemon caches env from its startup shell; dotenv (default no-override) then silently ignores .env values that conflict. Caused a 2-hour incident with a revoked GITHUB_ISSUES_TOKEN where only `pm2 kill` recovered.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dotenvтеперь грузится с{ override: true }— значения из.envвсегда перекрывают унаследованное окружение процесса.GITHUB_ISSUES_TOKENформа обратной связи продолжала отдавать 401 «Bad credentials», потому что PM2-демон кэшировал старый токен в собственном окружении, аdotenvпо умолчанию не перезаписывает уже существующие переменные.Почему это важно
Без override любая замена секрета в
.envтребовала полногоpm2 kill && pm2 startпод чистым шеллом (env -i). С override достаточно обычногоpm2 restartпосле правки.env.Что НЕ менял
__tests__/setup.tsоставил как есть — там override может поломать env, который CI/vitest конфигурируют вручную.dotenvуже вpackage.json, ничего не добавлял.Test plan
GITHUB_ISSUES_TOKENв.env,pm2 restart flowtask-api(безkill+env -i) — форма обратной связи отправляет issueDATABASE_URL,JWT_SECRET, и т.д.)