Closed
Conversation
matislovas
force-pushed
the
matislovas/upnp_start_after_wg_port_take_2
branch
from
8a942e5 to
bb317cb
Compare
sfraczek
reviewed
Mar 20, 2026
Comment on lines
+271
to
+272
| # With battery optiization disabl;ed, the uPnP pause() is inactive, so | ||
| # the port mappings can be created, even with paused provider |
Contributor
There was a problem hiding this comment.
typos: optiization, disabl;ed
| # With battery optiization disabl;ed, the uPnP pause() is inactive, so | ||
| # the port mappings can be created, even with paused provider | ||
| if not battery_optimization: | ||
| assert (len(mappings_search) <= 4) and (len(mappings_search) >= 2) |
Contributor
There was a problem hiding this comment.
Could you please explain where 2 or 4 is coming from?
…n nat-lab test Signed-off-by: Matas Misiunas <matislovas@gmail.com>
matislovas
force-pushed
the
matislovas/upnp_start_after_wg_port_take_2
branch
from
bb317cb to
0b96807
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When battery optimization is
on,upnpprovider does not react topause(), hence - it can create mappings even when paused.Solution
Differentiate the test for
battery_optimisation.☑️ Definition of Done checklist