[mlir] Replace int64_t sentinel for dynamic Sol_ArrayType size with std::optional<APInt>

[PavelKopyl]

NomicFoundation/solx-llvm#85

[Copilot]

Pull request overview

This PR updates the Solidity-to-MLIR lowering to align with the Sol MLIR dialect’s new representation for array sizes (replacing an int64_t dynamic-size sentinel with std::optional<llvm::APInt>), and adds regression coverage for extremely large static array sizes (up to 2**256 - 1).

Changes:

• Switch MLIR array type construction to use std::optional<llvm::APInt> (with std::nullopt for dynamic arrays) and preserve size via getSizeOpt().
• Add lit codegen tests that exercise uint[(2**256)-1] static arrays in both init-MLIR and EVM-MLIR output.
• Remove two entries from the MLIR semantic test known-failures list (indicating they are expected to pass now).

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File	Description
test/mlirSemtestFailures.txt	Removes two tests from the known-failures list.
test/lit/mlirCodegen/EVM/array-huge-static.sol	Adds EVM MLIR codegen regression test for max-sized static array type.
test/lit/mlirCodegen/array-huge-static.sol	Adds init MLIR regression test asserting correct printing of max-sized static array type.
libsolidity/codegen/mlir/SolidityToMLIR.cpp	Adapts array type lowering to use std::optional<APInt> size and getSizeOpt().

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[abinavpp]

thank you!

[Copilot]

Pull request overview

Copilot reviewed 11 out of 11 changed files in this pull request and generated no new comments.

Suppressed comments (1)

libsolidity/codegen/mlir/SolidityToMLIR.cpp:758

• The continuation line here is indented with a tab character, which breaks the file’s consistent spaces-only indentation and can cause inconsistent formatting in different editors.

    return mlir::sol::ArrayType::get(b.getContext(), /*size=*/std::nullopt,
									 eltTy, getDataLocation(&arrTy));

[abinavpp]

thank you!