[v2] feat(ast): add EventDefinition::compute_topic - #2037
Open
hedgar2017 wants to merge 1 commit into
Open
Conversation
Extract hash_from_signature as the keccak256 of a canonical signature; the 4-byte selector is its truncation and the event topic is the whole hash, so both derive from one primitive. Lets consumers read an event topic from the binder instead of hashing the signature themselves.
|
Contributor
|
Bencher Report| Branch | az-event-topic |
| Testbed | ci |
🐰 View full continuous benchmarking report in Bencher
⚠️ WARNING: Truncated view!The full continuous benchmarking report exceeds the maximum length allowed on this platform.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
hash_from_signatureas the keccak256 of a canonical signature; the 4-byte selector is its truncation and the event topic is the whole hash, so both derive from one primitive. Lets consumers read an event topic from the binder instead of hashing the signature themselves.