Major codebase cleanup and refactoring#9
Merged
MelbourneDeveloper merged 31 commits intomainfrom Mar 26, 2026
Merged
Conversation
docs/RUST-LSP-SPEC.md: comprehensive technical specification for rewriting CommandTree's 19 TypeScript parsers as a Rust LSP server using tree-sitter grammars, including custom JSON-RPC protocol, binary distribution strategy, VS Code client integration, and Zed/Neovim extension designs. docs/RUST-LSP-PLAN.md: phased implementation plan with checkboxes covering all 8 phases from Rust scaffold through Neovim plugin, plus a detailed VSIX bundling and CI/CD deployment checklist. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Tags AI/Copilot tests with @exclude-ci and updates CI workflow to skip them, preventing CI failures in environments without Copilot auth. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
docs/RUST-LSP-SPEC.md: comprehensive technical specification for rewriting CommandTree's 19 TypeScript parsers as a Rust LSP server using tree-sitter grammars, including custom JSON-RPC protocol, binary distribution strategy, VS Code client integration, and Zed/Neovim extension designs. docs/RUST-LSP-PLAN.md: phased implementation plan with checkboxes covering all 8 phases from Rust scaffold through Neovim plugin, plus a detailed VSIX bundling and CI/CD deployment checklist.
Tags AI/Copilot tests with @exclude-ci and updates CI workflow to skip them, preventing CI failures in environments without Copilot auth.
MelbourneDeveloper
added a commit
that referenced
this pull request
Mar 26, 2026
# TLDR; Large-scale cleanup: refactored providers, discovery modules, and tests for consistency, strict TypeScript compliance, and better code organization. # Details - **Refactored core providers** (`CommandTreeProvider`, `QuickTasksProvider`, `TagConfig`) — reduced complexity, improved functional style - **Reorganized semantic/db layer** — moved `db.ts` from `semantic/` to `db/`, added `lifecycle.ts`, removed unused embedding modules (`embedder.ts`, `embeddingPipeline.ts`, `similarity.ts`, `store.ts`, `types.ts`, `index.ts`) - **Added new discovery modules** — C# script (`csharp-script.ts`), F# script (`fsharp-script.ts`) discovery - **Extracted reusable code** — `powershellParser.ts`, `nodeFactory.ts`, `tagSync.ts`, `watchers.ts` - **Overhauled tests** — replaced fake/indirect tests with proper E2E tests, added unit tests (`discovery.unit.test.ts`, `modelSelection.unit.test.ts`, `taskRunner.unit.test.ts`, `treehierarchy.unit.test.ts`), removed Copilot-dependent and embedding tests - **CI improvements** — added format check, spell check, coverage threshold (90%), excluded Copilot-dependent tests - **Added docs** — split SPEC.md into focused doc files, added Rust LSP plan/spec - **Added Claude skills** — `ci-prep`, `fix-bug` for agent workflows - **ESLint/Prettier/tsconfig** tightened — stricter rules, consistent formatting - **Website** — minor content and config updates # How do the tests prove the change works - 65 unit tests pass covering tree hierarchy, model selection, task runner params, PowerShell parsing, and discovery logic - E2E tests cover all major user flows: discovery, execution, filtering, quick tasks, tagging, tree view, configuration, markdown, and AI summaries - CI enforces 90% coverage threshold on lines, functions, branches, and statements ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR;
Large-scale cleanup: refactored providers, discovery modules, and tests for consistency, strict TypeScript compliance, and better code organization.
Details
CommandTreeProvider,QuickTasksProvider,TagConfig) — reduced complexity, improved functional styledb.tsfromsemantic/todb/, addedlifecycle.ts, removed unused embedding modules (embedder.ts,embeddingPipeline.ts,similarity.ts,store.ts,types.ts,index.ts)csharp-script.ts), F# script (fsharp-script.ts) discoverypowershellParser.ts,nodeFactory.ts,tagSync.ts,watchers.tsdiscovery.unit.test.ts,modelSelection.unit.test.ts,taskRunner.unit.test.ts,treehierarchy.unit.test.ts), removed Copilot-dependent and embedding testsci-prep,fix-bugfor agent workflowsHow do the tests prove the change works