fix(iOS): emit ERROR event when adsLoader fails#2
Open
Ibad9 wants to merge 18 commits intoNextFaze:masterfrom
Open
fix(iOS): emit ERROR event when adsLoader fails#2Ibad9 wants to merge 18 commits intoNextFaze:masterfrom
Ibad9 wants to merge 18 commits intoNextFaze:masterfrom
Conversation
* feat: add DAI support * refactor!: unify CSAI and DAI configuration into single ad prop * fix(android): remove broken wait() in DAI initialization * feat(android): support HLS/DASH format in DAI * fix: lint formatting issues * refactor(android): simplify URI parsing * refactor(android): rename backupStreamUri to fallbackStreamUri for consistency * refactor: restore deleted comment * refactor: remove expo-dai example app * feat: add streamType field * refactor: simplify DAI config normalization * refactor: rename type value from dai to ssai * docs: replace DAI terminology with SSAI * docs: change ssai desc Co-authored-by: Kamil Moskała <91079590+moskalakamil@users.noreply.github.com> * fix(ios): conditional background playback for DAI based on PiP settings * fix: remove unused import --------- Co-authored-by: Maciej Budzinski <maciej.budzinski.93@gmail.com> Co-authored-by: Kamil Moskała <91079590+moskalakamil@users.noreply.github.com>
…Group#4771) * Fix IMA ad container not resizing on orientation change (iOS) * refactor: lint * chore: change comment text Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * refactor: remove redundant frame initialization --------- Co-authored-by: Ibad Ahmed <ibadahmed@Ibads-MacBook-Pro.local> Co-authored-by: Kamil Moskała <91079590+moskalakamil@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
On iOS, when IMA adsLoader fails before adsManager is initialized,
no event is emitted to JS, so
onReceiveAdEventis never triggered.Fix
Emit a
ERRORevent from:adsLoader(_:failedWith:)
Impact
Notes