Fix Windows (MSVC+MinGW) build#1461
Closed
StormBytePP wants to merge 2 commits intoNetflix:masterfrom
Closed
Conversation
StormBytePP
force-pushed
the
fix-msvc-build
branch
3 times, most recently
from
2ec2590 to
24d4f24
Compare
Contributor
Author
|
Now that PR #1460 have been merged, this one can be examined. Thanks |
StormBytePP
force-pushed
the
fix-msvc-build
branch
3 times, most recently
from
6191d9c to
c96f13d
Compare
StormBytePP
force-pushed
the
fix-msvc-build
branch
from
c96f13d to
1d3e0d7
Compare
Contributor
Author
|
I'm going to close this PR in order to redo it and add a proper native MSVC build support and also documented |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provided external pthread win32 implementation (like GerHobbelt pothread win32) libvmaf can be compiled with MSVC with the changes of this PR with no mingw need while other builds are not affected.