Skip to content

Comments

Use BUILD_SIGN_RELEASE env variable in release.yml workflow#461

Merged
jozefizso merged 2 commits intoreleases/netoffice_v1.9.8from
bugfix/460-correctly-sign-release-builds
Feb 21, 2026
Merged

Use BUILD_SIGN_RELEASE env variable in release.yml workflow#461
jozefizso merged 2 commits intoreleases/netoffice_v1.9.8from
bugfix/460-correctly-sign-release-builds

Conversation

@jozefizso
Copy link
Member

Fixes #460

@jozefizso jozefizso self-assigned this Feb 21, 2026
@jozefizso jozefizso added this to the 2.0.0 milestone Feb 21, 2026
@jozefizso jozefizso merged commit 979d37b into releases/netoffice_v1.9.8 Feb 21, 2026
2 checks passed
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a15cf657cf

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

'To release the NuGet package, upload the signing certificate to NuGet Gallery via Account Settings: <https://www.nuget.org/account>. ' >> $env:GITHUB_STEP_SUMMARY
'See the `certificate` artifact for the signing certificate file.' >> $env:GITHUB_STEP_SUMMARY
'' >> $env:GITHUB_STEP_SUMMARY
'Download the [certiticate file]($certUrl).' >> $env:GITHUB_STEP_SUMMARY

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Interpolate certificate URL in release summary

In the Release documentation step, the line writing Download the [certiticate file]($certUrl). is wrapped in single quotes, so PowerShell does not expand $certUrl and the job summary always shows a literal $certUrl link instead of the artifact URL. This breaks the newly added guidance for release operators in Release runs, forcing them to manually locate the certificate artifact.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant