Add progress indicators for search page#854
Open
SocratesDz wants to merge 2 commits intoNeoApplications:masterfrom
Open
Add progress indicators for search page#854SocratesDz wants to merge 2 commits intoNeoApplications:masterfrom
SocratesDz wants to merge 2 commits intoNeoApplications:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds progress indicators for the initial state of the Search page and while using the search bar input field.
Note there's a debounce operator for the search input field of 400ms, however users expect to have visual feedback on their actions in about 200ms in order to keep a "snappy" feeling on the app. The initial loading state was added based on the same reasoning.
The work here is related to #623 and #678.
no_loading_indicators.mp4
with_loading_indicators.mp4