shrink the size of the type-erasing wrappers#2063
Merged
ericniebler merged 2 commits intoNVIDIA:mainfrom May 4, 2026
Merged
Conversation
ericniebler
force-pushed
the
shrink-type-erasing-wrappers
branch
from
66efd4e to
d966791
Compare
| class _BaseInterfaces = __extends<>, | ||
| size_t _BufferSize = __default_buffer_size, | ||
| size_t _BufferAlignment = alignof(std::max_align_t)> | ||
| size_t _BufferAlignment = alignof(void *)> |
Contributor
There was a problem hiding this comment.
Would it be worth adding a small test that checks the sizeof ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__any-based type-erasing wrappers are wasting space by over-aligning the internal buffer by default. this PR changes the default buffer alignment fromalignof(std::max_align_t)toalignof(void*). this eliminates two pointers worth of padding in the representation of__any<ifooable>.