Drop old/unsupported skaffold and docker-compose files - #4507
Open
kensimon wants to merge 1 commit into
Open
Conversation
These date back to older ways of deploying nico (nee carbide) before the Helm chart and devspace were a thing. They don't work by themselves any more, you need nvidia-internal things external to the repo for them to work. Drop them to eliminate confusion. (Note to anyone NVIDIA-internal who still needs these: You can check them out from an older version, then locally ignore them by adding their paths to .git/info/exclude and then you'll have your own copy of them.)
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
💤 Files with no reviewable changes (3)
Summary by CodeRabbit
WalkthroughThe PR deletes the local container build script, Docker Compose stack definition, and Skaffold deployment configuration. Changes
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
10 tasks
poroh
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These date back to older ways of deploying nico (nee carbide) before the Helm chart and devspace were a thing. They don't work by themselves any more, you need nvidia-internal things external to the repo for them to work. Drop them to eliminate confusion.
Related issues
Type of Change
Breaking Changes
The files never worked without nvidia-internal bits anyway, so it's not breaking anything public.
Note to anyone NVIDIA-internal who still needs these: You can check them out from an older version, then locally ignore them by adding their paths to
.git/info/excludeand then you'll have your own copy of them that stays put across branches.Testing
Additional Notes