Add patch verb to carbide-api DPF secrets RBAC dpf docs - #4485
Add patch verb to carbide-api DPF secrets RBAC dpf docs#4485aadvani-nvidia wants to merge 2 commits into
Conversation
Signed-off-by: aadvani <aadvani@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
Summary by CodeRabbit
WalkthroughThe DPF RBAC Role now permits the NICo orchestrator to patch Secrets in addition to getting and creating them. ChangesDPF RBAC permissions
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pull-request-4485.docs.buildwithfern.com/infra-controller |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/manuals/dpf.md`:
- Line 471: Synchronize the Secrets permission with the documented access by
updating the setup-applied Role in helm-prereqs/setup-machine-a-tron.sh to
include "patch" alongside "get" and "create"; if patching is intentionally
unsupported there, instead add a canonical explanation and link the
documentation to it.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: ab1ff06e-9491-48c5-acdc-80b2bb0c0272
📒 Files selected for processing (1)
docs/manuals/dpf.md
Signed-off-by: aadvani <aadvani@nvidia.com>
Add patch verb to carbide-api DPF secrets RBAC dpf docs
Related issues
Type of Change
Breaking Changes
Testing
Additional Notes