Skip to content

Add patch verb to carbide-api DPF secrets RBAC dpf docs - #4485

Open
aadvani-nvidia wants to merge 2 commits into
NVIDIA:mainfrom
aadvani-nvidia:dpf-rbac-patch
Open

Add patch verb to carbide-api DPF secrets RBAC dpf docs#4485
aadvani-nvidia wants to merge 2 commits into
NVIDIA:mainfrom
aadvani-nvidia:dpf-rbac-patch

Conversation

@aadvani-nvidia

Copy link
Copy Markdown
Contributor

Add patch verb to carbide-api DPF secrets RBAC dpf docs

Related issues

Type of Change

  • Add - New feature or capability
  • Change - Changes in existing functionality
  • Fix - Bug fixes
  • Remove - Removed features or deprecated functionality
  • Internal - Internal changes (refactoring, tests, docs, etc.)

Breaking Changes

  • This PR contains breaking changes

Testing

  • Unit tests added/updated
  • Integration tests added/updated
  • Manual testing performed
  • No testing required (docs, internal refactor, etc.)

Additional Notes

Signed-off-by: aadvani <aadvani@nvidia.com>
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7bdfad58-a53a-456d-a5a1-d2acf6828015

📥 Commits

Reviewing files that changed from the base of the PR and between 817d919 and 8d0cca8.

📒 Files selected for processing (2)
  • helm-prereqs/setup-machine-a-tron.sh
  • helm/charts/nico-api/templates/dpf-rbac.yaml

Summary by CodeRabbit

  • New Features
    • DPF Role now supports patching Secrets, in addition to retrieving and creating them.

Walkthrough

The DPF RBAC Role now permits the NICo orchestrator to patch Secrets in addition to getting and creating them.

Changes

DPF RBAC permissions

Layer / File(s) Summary
Secret patch permission
helm/charts/nico-api/templates/dpf-rbac.yaml, helm-prereqs/setup-machine-a-tron.sh, docs/manuals/dpf.md
The DPF RBAC Role grants patch access to Secrets alongside get and create access. The Helm template, setup script, and documentation contain the updated permission set.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the addition of the patch verb to DPF secrets RBAC documentation.
Description check ✅ Passed The description accurately relates the RBAC documentation change and states that no testing is required.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/manuals/dpf.md`:
- Line 471: Synchronize the Secrets permission with the documented access by
updating the setup-applied Role in helm-prereqs/setup-machine-a-tron.sh to
include "patch" alongside "get" and "create"; if patching is intentionally
unsupported there, instead add a canonical explanation and link the
documentation to it.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ab1ff06e-9491-48c5-acdc-80b2bb0c0272

📥 Commits

Reviewing files that changed from the base of the PR and between 47b4d3a and 817d919.

📒 Files selected for processing (1)
  • docs/manuals/dpf.md

Comment thread docs/manuals/dpf.md
Signed-off-by: aadvani <aadvani@nvidia.com>
@aadvani-nvidia
aadvani-nvidia requested a review from a team as a code owner August 3, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants