feat(taxonomy): show full breadcrumb path for technique leaves - #1988
feat(taxonomy): show full breadcrumb path for technique leaves#1988AbdaullahAG wants to merge 3 commits into
Conversation
1f0ae87 to
49f5d8c
Compare
acbb535 to
9b591bb
Compare
|
Hi @otavionvidia , thanks for reviewing! A quick summary to help with the review: this PR implements the Key points:
Happy to address any feedback! |
jmartin-tech
left a comment
There was a problem hiding this comment.
While I am not against the location this was added it is not as aligned with the existing UX as I would have preferred.
The tags are displayed when a probe or probe grouping slug is expanded to show the graph details.
The current PR places these new values in the title slug visible before expanding with no label to explain what they represent.
Open to keeping as is, would like more viewpoints in review.
Intent codes are flat (e.g. C006) and carry no path information in
the digest, so the breadcrumb only applies to the technique axis.
Intent code can be deferred to a future revision, additions are needed in the digest to provide the hierarchy needed for extended mapping.
…A#1972) Signed-off-by: AbdaullahAG <abd.moh9999@yahoo.com>
Signed-off-by: AbdaullahAG <abd.moh9999@yahoo.com>
…review Signed-off-by: AbdaullahAG <abd.moh9999@yahoo.com>
22d1556 to
b202983
Compare
Addresses #1972 — implements the "All leaves" breadcrumb path.
Summary
Surfaces the taxonomy path for technique leaves in the Techniques and
Intents report, per @jmartin-tech's guidance in #1972: reuses the
existing tag-style UI from the Probes view (
ProbeTagsList) ratherthan introducing a new visual pattern.
Context
As clarified in the issue thread, the
groupview proposed in theoriginal report is not part of the initial technique/intent view
landing, so this PR implements the still-viable standalone piece:
showing the full taxonomy path for a technique leaf (e.g.
Fictionalizing › Roleplaying › User_persona) instead of just theshortened last-two-segment label.
Intent codes are flat (e.g.
C006) and carry no path information inthe digest, so the breadcrumb only applies to the technique axis.
Changes
utils/taxonomyLabels.ts: addedisTechniqueKey()andtechniquePathSegments(), returning the full branch chain insteadof
shortenTechnique()'s last-two truncation.components/TechniqueIntent/TaxonomyPathBadges.tsx(new): rendersthe path as a chevron-separated chain of gray outline badges,
matching
ProbeChart/ProbeTagsList.tsx's styling exactly.components/TechniqueIntent/TaxonomyAxisList.tsx: wired thebreadcrumb into two places, generically (checks whether a key is a
technique key, regardless of which axis is primary):
technique.
TechniqueIntent/index.ts,components/index.ts)updated to expose the new component.
No business logic, scoring, or report calculations were touched —
this is purely presentational.
Testing
isTechniqueKey/techniquePathSegments.TaxonomyPathBadges(segment order, tag styling,empty-state for single-segment keys).
TaxonomyAxisList.test.tsxwith a hierarchical fixture keyto cover breadcrumb presence/absence on both the technique and
intent axes.
##Note
the "Grouped" leaf-listing half of the original request depends
on functionality not yet landed (per @jmartin-tech's comment), so this
PR covers the "All leaves" path portion as a standalone enhancement.