Skip to content

feat(taxonomy): show full breadcrumb path for technique leaves - #1988

Open
AbdaullahAG wants to merge 3 commits into
NVIDIA:mainfrom
AbdaullahAG:feature/issue-1972-leaf-path
Open

feat(taxonomy): show full breadcrumb path for technique leaves#1988
AbdaullahAG wants to merge 3 commits into
NVIDIA:mainfrom
AbdaullahAG:feature/issue-1972-leaf-path

Conversation

@AbdaullahAG

Copy link
Copy Markdown

Addresses #1972 — implements the "All leaves" breadcrumb path.

Summary

Surfaces the taxonomy path for technique leaves in the Techniques and
Intents report, per @jmartin-tech's guidance in #1972: reuses the
existing tag-style UI from the Probes view (ProbeTagsList) rather
than introducing a new visual pattern.

Context

As clarified in the issue thread, the group view proposed in the
original report is not part of the initial technique/intent view
landing, so this PR implements the still-viable standalone piece:
showing the full taxonomy path for a technique leaf (e.g.
Fictionalizing › Roleplaying › User_persona) instead of just the
shortened last-two-segment label.

Intent codes are flat (e.g. C006) and carry no path information in
the digest, so the breadcrumb only applies to the technique axis.

Changes

  • utils/taxonomyLabels.ts: added isTechniqueKey() and
    techniquePathSegments(), returning the full branch chain instead
    of shortenTechnique()'s last-two truncation.
  • components/TechniqueIntent/TaxonomyPathBadges.tsx (new): renders
    the path as a chevron-separated chain of gray outline badges,
    matching ProbeChart/ProbeTagsList.tsx's styling exactly.
  • components/TechniqueIntent/TaxonomyAxisList.tsx: wired the
    breadcrumb into two places, generically (checks whether a key is a
    technique key, regardless of which axis is primary):
    • Under a group's label when the group itself is a technique leaf.
    • Under a pairing's detail title when the cross-axis key is a
      technique.
  • Barrel exports (TechniqueIntent/index.ts, components/index.ts)
    updated to expose the new component.

No business logic, scoring, or report calculations were touched —
this is purely presentational.

Testing

  • Added unit tests for isTechniqueKey/techniquePathSegments.
  • Added tests for TaxonomyPathBadges (segment order, tag styling,
    empty-state for single-segment keys).
  • Extended TaxonomyAxisList.test.tsx with a hierarchical fixture key
    to cover breadcrumb presence/absence on both the technique and
    intent axes.
  • Full suite: 298/298 tests passing, no regressions.

##Note
the "Grouped" leaf-listing half of the original request depends
on functionality not yet landed (per @jmartin-tech's comment), so this
PR covers the "All leaves" path portion as a standalone enhancement.

@AbdaullahAG

Copy link
Copy Markdown
Author

Hi @otavionvidia , thanks for reviewing!
(cc @jmartin-tech, since you requested the review — happy to loop you in on anything.)

A quick summary to help with the review: this PR implements the
standalone enhancement discussed in #1972 (surfacing the technique's
full taxonomy path), following @jmartin-tech's guidance to reuse the
ProbeTagsList tag styling rather than introduce a new pattern.

Key points:

  • Purely presentational — no business logic, scoring, or report
    calculations touched.
  • New component: TaxonomyPathBadges.tsx, wired into
    TaxonomyAxisList.tsx in two spots (group label + pairing detail).
  • Intent codes are flat (no hierarchy in the digest), so the
    breadcrumb only applies to the technique axis.
  • Full test coverage added for the new helpers/component; 298/298
    tests passing, no regressions.

Happy to address any feedback!

@patriciapampanelli patriciapampanelli changed the title feat(taxonomy): show full breadcrumb path for technique leaves (#1972) feat(taxonomy): show full breadcrumb path for technique leaves Jul 30, 2026

@jmartin-tech jmartin-tech left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I am not against the location this was added it is not as aligned with the existing UX as I would have preferred.

The tags are displayed when a probe or probe grouping slug is expanded to show the graph details.

Image Image

The current PR places these new values in the title slug visible before expanding with no label to explain what they represent.

Image

Open to keeping as is, would like more viewpoints in review.

Intent codes are flat (e.g. C006) and carry no path information in
the digest, so the breadcrumb only applies to the technique axis.

Intent code can be deferred to a future revision, additions are needed in the digest to provide the hierarchy needed for extended mapping.

Signed-off-by: AbdaullahAG <abd.moh9999@yahoo.com>
…review

Signed-off-by: AbdaullahAG <abd.moh9999@yahoo.com>
@AbdaullahAG
AbdaullahAG force-pushed the feature/issue-1972-leaf-path branch from 22d1556 to b202983 Compare July 31, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants