Improve FlashVSR gRPC server - #459
Merged
Merged
Conversation
Signed-off-by: Gangzheng Tong <gtong@nvidia.com>
gtong-nv
marked this pull request as ready for review
August 13, 2026 23:59
Collaborator
Author
|
/ok to test 3a9a185 |
Contributor
Greptile SummaryThe PR restricts FlashVSR’s gRPC server and browser viewer to loopback by default and adds random bearer tokens to protect unary session operations.
Confidence Score: 4/5The PR appears safe to merge, with a non-blocking rollout-compatibility concern for previously generated unary clients. Token propagation is correct for the bundled client, but clients that omit the new field are denied both processing and cleanup, leaving their allocated sessions resident. Files Needing Attention: integrations/flashvsr/flashvsr/grpc/protos/flashvsr.proto, integrations/flashvsr/flashvsr/grpc/uplift_server.py Important Files Changed
Sequence DiagramsequenceDiagram
participant Client
participant Server
Client->>Server: start_session(config)
Server-->>Client: session_id + session_token
loop Each unary chunk
Client->>Server: upscale_chunk(session_id, token, frames)
Server->>Server: Validate token and update cache
Server-->>Client: Upscaled frames
end
Client->>Server: end_session(session_id, token)
Server->>Server: Validate token and release session
Server-->>Client: success
Reviews (1): Last reviewed commit: "Merge branch 'main' into dev/gtong/fix-f..." | Re-trigger Greptile |
Comment on lines
+84
to
+85
| // Unforgeable credential required by subsequent unary session calls. | ||
| string session_token = 4; |
Contributor
aidanfnv
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.