WIP: op is used instead of cur_op #41
Open
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Niklas Hansson <[email protected]>
NikeNano
force-pushed
the
nikenano/PotentialTypo
branch
from
c2e07b1 to
04738c9
Compare
NikeNano
commented
Dec 23, 2025
| has_acquire_order = False | ||
| if isinstance(cur_op, (TileAtomicCAS, TileAtomicRMW)): | ||
| has_acquire_order = memory_order_has_acquire(op.memory_order) | ||
| has_acquire_order = memory_order_has_acquire(cur_op.memory_order) |
Contributor
Author
There was a problem hiding this comment.
Should this be the outer or inner variable? I tried to read through the code and could not find any cases where we did not want the cur_op
Contributor
Author
|
Leave it open for questions, but will need to spin up a gpu to test this as well so leave it as WIP, if that is fine. |
NikeNano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should not have any changes on the implementation other than cleaning up a potential typo and making the code more consistent.
Checklist