Remove redundant checks and tried to simplify some if else. #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikeNano
force-pushed
the
nikenano/SimplifyCode
branch
from
8273ce2 to
f324575
Compare
Signed-off-by: Niklas Hansson <[email protected]>
Signed-off-by: Niklas Hansson <[email protected]>
NikeNano
force-pushed
the
nikenano/SimplifyCode
branch
from
f324575 to
6373e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When reading through the code I noticed an unnecessary condition and early returns. Updated to simplify the code by flattening the structure and remove condition that is already checked. Let me know if I am nit picking to much. Juste likes to update things when I go over to help on open source projects and cuTile seems like an awesome project, thanks!
Checklist