Revert "Revert "Fix get_nested_resource_ptr to accept both str and bytes inputs""#1698
Open
Revert "Revert "Fix get_nested_resource_ptr to accept both str and bytes inputs""#1698
Conversation
…tes inpu…" This reverts commit 2d85f3e.
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Collaborator
Author
|
/ok to test |
|
Collaborator
Author
|
/ok to test |
leofang
reviewed
Feb 27, 2026
Comment on lines
-126
to
+134
| obj_i_ptr = <char*>(obj_i_bytes) | ||
| obj_i_ptr = PyBytes_AsString(obj_i_bytes) |
Member
There was a problem hiding this comment.
In general we should let Cython figure out the correct C API to use, and not intervene with manual C API calls unless we can prove
- Cython emits wrong code, or
- We can do it with an equally safe but more performant way
| nvjitlink.destroy(handle) | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("option", ARCHITECTURES) |
Member
There was a problem hiding this comment.
no need to parametrize it, just one bytes instance is fine
Comment on lines
+118
to
+120
| @pytest.mark.parametrize( | ||
| "options", [[], ["-opt=0"], ["-opt=3", "-g"], [b"-opt=0"], [b"-opt=3", b"-g"], ["-opt=3", b"-g"]] | ||
| ) |
Comment on lines
+140
to
+142
| @pytest.mark.parametrize( | ||
| "options", [[], ["-opt=0"], ["-opt=3", "-g"], [b"-opt=0"], [b"-opt=3", b"-g"], ["-opt=3", b"-g"]] | ||
| ) |
Member
There was a problem hiding this comment.
ditto; also, if this is already tested above, no need to test again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1697