Standardize naming conventions across cuda.core examples#1695
Open
cpcloud wants to merge 4 commits intoNVIDIA:mainfrom
Open
Standardize naming conventions across cuda.core examples#1695cpcloud wants to merge 4 commits intoNVIDIA:mainfrom
cpcloud wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
- Remove success/completion fluff messages ("done!", "passed", etc.)
- Use sys.exit(1) instead of sys.exit(0) for unsupported configurations
- Send skip/warning/error messages to stderr
- Replace user-facing assert with proper checks
- Standardize sys.exit(-1) to sys.exit(1)
Made-with: Cursor
Made-with: Cursor
The _test.py files in cuda_bindings/examples/ are run under pytest, so sys.exit(1) for unsupported configurations causes SystemExit(1) which pytest treats as a test failure. Use pytest.skip() instead for platform/device/capability checks that indicate unsupported configs. Actual test failures (incorrect results) still use sys.exit(1). Made-with: Cursor
Apply consistent variable names for common objects across all cuda.core example files, addressing issue NVIDIA#1675. Conventions applied: - Stream: `stream` (not `s`), numbered `stream0`/`stream1` - Kernel: `kernel` (not `ker`/`gpu_ker`), descriptive `add_kernel`/`sub_kernel` - Program: `prog` (not `gpu_prog`) - Kernel args: `kernel_args` (not `ker_args`) - Program options: `program_options` (not `opts`), using ProgramOptions (not dicts) - Grid/block: `grid`/`block` (not `grid_size`/`block_size`) Made-with: Cursor
cpcloud
force-pushed
the
examples-naming-conventions
branch
from
d6a8f91 to
76978c1
Compare
Contributor
Author
|
/ok to test |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #1675 — standardize variable names for common objects across all
cuda.coreexample files.Note: This PR is based on #1694 (
examples-stderr-out) and should be merged after it.Conventions applied
streamstream0,stream1kerneladd_kernel,sub_kernelprogprogram_options(usingProgramOptions)modconfigconfig0,config1grid/blockkernel_argsChanges by file
vector_add.py:s→stream,ker→kernelsaxpy.py:s→stream,ker→kernel,ker_args→kernel_argspytorch_example.py:s→stream,ker→kernel,ker_args→kernel_argsthread_block_cluster.py:ker→kernelstrided_memory_view_gpu.py:s→stream,gpu_ker→kernel,gpu_prog→progsimple_multi_gpu_example.py:ker_add→add_kernel,ker_sub→sub_kernel, dict options →ProgramOptionscuda_graphs.py:block_size/grid_size→block/gridgl_interop_plasma.py:opts→program_optionsTest plan
Made with Cursor