Conversation
…cted ATIF-native changes (#1853) **Why** Limit the changes in 1.6.0 to evaluation system only **Summary** This PR restores profiler behavior to be compatible with IntermediateStep (IST) workflows while preserving selected newer functional changes (notably optimizer extraction and other non-profiler updates). The revert was done surgically by reversing only packages/nvidia_nat_profiler changes from specific commits, then applying minimal compatibility fixes. **Revert Strategy (step-by-step)** - Reverse-applied profiler-only changes from: - 7c46d71 - 2490e5d - ebc46e7 - Used path-limited reverse patching so only packages/nvidia_nat_profiler was affected: - git diff <sha>^! -- packages/nvidia_nat_profiler | git apply -R -3 --index - Kept newer desired changes outside this rollback scope (including optimizer extraction commit lineage). - Fixed compatibility fallout introduced by mixed old/new code paths - Updated eval runtime profiler handoff to IST - In packages/nvidia_nat_eval/src/nat/plugins/eval/runtime/evaluate.py, profiler input now uses IST trajectories from self.eval_input.eval_input_items. **Key Files Touched** - packages/nvidia_nat_profiler/... (revert scope and compatibility fixes) - packages/nvidia_nat_eval/src/nat/plugins/eval/runtime/evaluate.py (IST profiler handoff + ATIF trigger condition) ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/NVIDIA/NeMo-Agent-Toolkit/blob/develop/docs/source/resources/contributing/index.md). - We require that all contributors "sign-off" on their commits. This certifies that the contribution is your original work, or you have rights to submit it under the same license, or a compatible license. - Any contribution which contains commits that are not Signed-Off will not be accepted. - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. ## Summary by CodeRabbit * **Refactor** * Profiler pipeline moved to an intermediate step-based flow and now accepts nested list inputs only; DataFrame-based ingestion and ATIF-to-DataFrame utilities removed. * Multiple analysis modules and forecasting/trainer APIs now expect list-based step inputs (DataFrame/Sequence support removed). * LLM latency and related metrics now derive timestamps from standardized step fields. * **Tests** * Test suite updated to exercise the new list-based profiler input paths; legacy ATIF/DataFrame tests and helpers removed. Authors: - Anuradha Karuppiah (https://github.com/AnuradhaKaruppiah) Approvers: - Yuchen Zhang (https://github.com/yczhang-nv) URL: #1853
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/1.6 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.