Fix documentation switcher generation for 2.+ releases#6246
Fix documentation switcher generation for 2.+ releases#6246JanuszL merged 1 commit intoNVIDIA:mainfrom
Conversation
- The documentation switcher previously assumed a 1 major current version and did not handle cases for 2.+. This PR resolves that issue and adds a TODO for supporting additional major release logic if needed in the future. Signed-off-by: Janusz Lisiecki <jlisiecki@nvidia.com>
|
!build |
Greptile SummaryThis PR successfully fixes the documentation version switcher in What changed:
Assessment: Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Start: parse version_short] --> B["Extract v_major and v_minor\nfrom version_short"]
B --> C["Loop: range(0, v_minor + correction)\nAppend v_major.i entries<br/>for current major version"]
C --> D["TODO: handle major releases\n2..current-1"]
D --> E["Pre-2.0 loop: range(10, 54)\nAppend 1.10–1.53<br/>with short_user for >= 34"]
E --> F["Append 1.0–1.9<br/>with legacy dali_1i0 format"]
F --> G["Append 0.x versions<br/>with various formats"]
G --> H["Sort by Version descending"]
H --> I["Insert current release at index 0"]
I --> J["Insert 'main unstable' at index 1"]
J --> K["Trim to 10 entries"]
K --> L["Append 'older releases' link"]
L --> M["Validate and write switcher.json"]
Last reviewed commit: 3c04ab3 |
1 similar comment
Greptile SummaryThis PR successfully fixes the documentation version switcher in What changed:
Assessment: Confidence Score: 5/5
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Start: parse version_short] --> B["Extract v_major and v_minor\nfrom version_short"]
B --> C["Loop: range(0, v_minor + correction)\nAppend v_major.i entries<br/>for current major version"]
C --> D["TODO: handle major releases\n2..current-1"]
D --> E["Pre-2.0 loop: range(10, 54)\nAppend 1.10–1.53<br/>with short_user for >= 34"]
E --> F["Append 1.0–1.9<br/>with legacy dali_1i0 format"]
F --> G["Append 0.x versions<br/>with various formats"]
G --> H["Sort by Version descending"]
H --> I["Insert current release at index 0"]
I --> J["Insert 'main unstable' at index 1"]
J --> K["Trim to 10 entries"]
K --> L["Append 'older releases' link"]
L --> M["Validate and write switcher.json"]
Last reviewed commit: 3c04ab3 |
|
!build |
|
CI MESSAGE: [45298725]: BUILD STARTED |
|
CI MESSAGE: [45298725]: BUILD FAILED |
|
CI MESSAGE: [45298725]: BUILD PASSED |
current version and did not handle cases for 2.+.
This PR resolves that issue and adds a TODO for supporting
additional major release logic if needed in the future.
Category:
Bug fix (non-breaking change which fixes an issue)
Description:
current version and did not handle cases for 2.+.
This PR resolves that issue and adds a TODO for supporting
additional major release logic if needed in the future.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A