Use AccessOrder in TypeInfo::Copy. Add synchronization when specifying host order for x2D and D2x copy.#5557
Draft
mzient wants to merge 2 commits intoNVIDIA:mainfrom
Draft
Use AccessOrder in TypeInfo::Copy. Add synchronization when specifying host order for x2D and D2x copy.#5557mzient wants to merge 2 commits intoNVIDIA:mainfrom
mzient wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Add synchronization when specifying host order for x2D and D2x copy. Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Collaborator
|
CI MESSAGE: [16474477]: BUILD STARTED |
Signed-off-by: Michal Zientkiewicz <michalz@nvidia.com>
Collaborator
|
CI MESSAGE: [16474871]: BUILD STARTED |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category:
Bug fix (non-breaking change which fixes an issue)
Refactoring (Redesign of existing code that doesn't affect functionality)
Description:
Additional information:
Before this change specifying AccessOrder::host in x2D pr D2x copy resulted in missing synchronization. It should be either forbidden or properly synchronized.
Affected modules and functionalities:
Tensor & TensorList copying.
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A