[RFC] Draft of validation utilites - focusing on type checking#5400
Draft
klecki wants to merge 4 commits intoNVIDIA:mainfrom
Draft
[RFC] Draft of validation utilites - focusing on type checking#5400klecki wants to merge 4 commits intoNVIDIA:mainfrom
klecki wants to merge 4 commits intoNVIDIA:mainfrom
Conversation
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
Signed-off-by: Krzysztof Lecki <klecki@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krzysztof Lecki klecki@nvidia.com<!---
Thank you for contributing to NVIDIA DALI! If you haven't yet,
please read the contributing guidelines in the CONTRIBUTING.md file.
We need a few more information from you to proceed.
Please fill the relevant sections in this PR template.
Fields in the Checklist section can be marked after you create and save the Pull Request.
--->
Category: New feature
Description:
In error_reporting.h set of overloads for checking type of inputs, outputs, arguments and the
dtypeis provided.Usage is applied to selected operator.
Possible extension of validation tools is explained, but it seems that this approach may be a little bit too constraining and verbose at the same time.
Additional information:
Affected modules and functionalities:
Key points relevant for the review:
Tests:
Checklist
Documentation
DALI team only
Requirements
REQ IDs: N/A
JIRA TASK: N/A