Fix duplicate issue creation in weekly link check#773
Open
underwoo wants to merge 1 commit into
Open
Conversation
Add URL-level deduplication to prevent the weekly link check workflow from creating multiple issues for the same broken link. Changes: - Add extract_known_urls.py to parse URLs from open issue bodies - Update report_linkcheck.py to accept --known-urls-file argument - Add exit code 3 for when all broken links are already tracked - Known broken links show 'Related to #NNN' in the Status column - Only create new issues when genuinely new broken links are found Fixes NOAA-RDHPCS#772
This was referenced Jun 16, 2026
elisabethpatterson
pushed a commit
that referenced
this pull request
Jun 23, 2026
* Add hash-pinned dependencies for supply chain security (#774) - Create requirements.in with direct dependencies - Generate requirements.txt with pip-compile --generate-hashes - Add codeowners package for CODEOWNERS file parsing - Add CI workflow to verify requirements stay in sync - Document dependency management process in CONTRIBUTING.md * Auto-assign broken link issues to code owners (#774) - Add resolve_assignees.py to parse CODEOWNERS and select assignees - Update weekly link check workflow to assign issues after creation - Ensures at least one owner per affected file is assigned - Respects GitHub's 10-assignee limit - Uses fallback owner when no specific owner exists Related to #772 and PR #773 --------- Co-authored-by: Chan Wilson <cwilson@meadow.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #772
The weekly link check workflow was creating duplicate issues for the same broken link across multiple weeks (e.g., issues #742, #747, #750, and #755 all referenced the same broken
http://www.nedit.org/URL).Changes
New file:
.github/scripts/extract_known_urls.pyModified:
.github/scripts/report_linkcheck.py--known-urls-fileargument to accept known URLs3when all broken links are already tracked (skips issue creation)Modified:
.github/workflows/weekly_check_all_links.yml1(new broken links found)Behavior
Testing
Tested locally with mock data simulating various scenarios (all new, all known, mixed, none broken).